Mongodb support for partial updates. - #380

connectors/mongo/connector_test.go (1)

68-77: Test helpers swallow/abuse Decode — small robustness fix.

• assertDoc ignores the Decode error; if FindOne fails for a reason other than "document missing", res will be nil and the assert.Equal message will misleadingly point at a value mismatch instead of the underlying driver error.
• assertNoDoc passes nil to Decode, which is fragile (behavior when the document unexpectedly exists depends on driver internals). Prefer .Err() to check the not-found condition directly.

♻️ Suggested change

 func assertDoc(t *testing.T, col *mongo.Collection, expected map[string]string) {
 	var res map[string]string
-	col.FindOne(t.Context(), bson.M{"_id": expected["_id"]}).Decode(&res)
+	require.NoError(t, col.FindOne(t.Context(), bson.M{"_id": expected["_id"]}).Decode(&res))
 	assert.Equal(t, expected, res)
 }

 func assertNoDoc(t *testing.T, col *mongo.Collection, id string) {
-	err := col.FindOne(t.Context(), bson.M{"_id": id}).Decode(nil)
-	assert.ErrorIs(t, err, mongo.ErrNoDocuments)
+	assert.ErrorIs(t, col.FindOne(t.Context(), bson.M{"_id": id}).Err(), mongo.ErrNoDocuments)
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@connectors/mongo/connector_test.go` around lines 68 - 77, assertDoc currently
ignores the error from FindOne().Decode which can hide driver errors and produce
misleading assertions; change assertDoc to capture and assert.NoError on the
Decode call (e.g., err := col.FindOne(...).Decode(&res); assert.NoError(t, err))
before asserting equality with expected, and in assertNoDoc replace the
Decode(nil) usage with checking the FindOne(...).Err() result (e.g., err :=
col.FindOne(...).Err(); assert.ErrorIs(t, err, mongo.ErrNoDocuments)) to
reliably detect the "not found" condition; update the functions named assertDoc
and assertNoDoc accordingly.

connectors/mongo/conn.go (2)

1010-1025: Duplicated idKeys map build.

stripIdFields (line 925) already constructed the same idKeys set from idFilter. Rebuilding it here is redundant; you could either hoist the set above the switch or expose a helper that returns it from stripIdFields. Minor, but removes duplication and one allocation per partial update.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@connectors/mongo/conn.go` around lines 1010 - 1025, The idKeys map is rebuilt
redundantly inside the partial-unset block; reuse the idKeys computed by
stripIdFields instead of allocating a new map. Modify stripIdFields to either
return the idKeys set alongside its current result or compute idKeys once before
the switch that handles partial updates, then reference that idKeys in the
partial-unset logic (the code using idFilter and
update.GetPartialUpdateUnset()). Remove the inner idKeys construction to
eliminate the duplicate allocation.

---

979-984: Dead assignment in the isNew branch.

lastType is only consulted in the !isNew branches of each case below; when isNew is true the code always appends to models regardless of lastType. The lastType = update.GetType() assignment is never read. Either drop it, or simplify by only tracking "was the last op a partial update" in seen (a map[string]bool), which also removes the adiomv1.UpdateType import-coupling on what is really a boolean signal.

♻️ Minor simplification

-	seen := map[string]adiomv1.UpdateType{}
+	lastIsPartial := map[string]bool{}

 	for i := len(updates) - 1; i >= 0; i-- {
 		update := updates[i]
 		idFilter, idKey, err := c.buildIdFilter(update)
 		if err != nil {
 			return nil, false, err
 		}

-		lastType, found := seen[idKey]
-		isNew := !found
-		if isNew {
-			seen[idKey] = update.GetType()
-			lastType = update.GetType()
-		}
+		last, found := lastIsPartial[idKey]
+		isNew := !found
+		if isNew {
+			lastIsPartial[idKey] = update.GetType() == adiomv1.UpdateType_UPDATE_TYPE_PARTIAL_UPDATE
+			last = lastIsPartial[idKey]
+		}

Then replace lastType == adiomv1.UpdateType_UPDATE_TYPE_PARTIAL_UPDATE with last.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@connectors/mongo/conn.go` around lines 979 - 984, The dead assignment sets
lastType = update.GetType() in the isNew branch but lastType is only used for
non-new paths; remove this unused assignment and simplify the seen map to track
only whether the last op was a partial update (e.g., change seen from
map[string]adiomv1.UpdateType to map[string]bool or a new seenPartial map keyed
by idKey), update the branch that sets seen[idKey] to store a boolean (true if
update.GetType() == adiomv1.UpdateType_UPDATE_TYPE_PARTIAL_UPDATE), and replace
all uses of lastType == adiomv1.UpdateType_UPDATE_TYPE_PARTIAL_UPDATE with the
boolean flag (e.g., last) so models appending logic remains correct and the
adiomv1 type coupling is removed; also drop the now-unread lastType variable and
its assignment in the isNew branch.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes